-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/9e9SRbL79YhKiD2p4REf7rN6QfJr |
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
- Coverage 30.43% 30.39% -0.04%
==========================================
Files 497 497
Lines 10000 9995 -5
Branches 1689 1688 -1
==========================================
- Hits 3043 3038 -5
Misses 6711 6711
Partials 246 246
Continue to review full report at Codecov.
|
… into fix/color_consistency
packages/superset-ui-core/src/color/CategoricalColorNamespace.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 non blocking comments, looks good!
… into fix/color_consistency
Hi @geido, in our last weekly release, we saw a bug where Time Series Area Charts have no fill color. I am guessing it is related to this change. Can you take a look? Current behavior (superset apache/master, 2021-11-04) |
Hey @serenajiang! This bug was introduced in #1447 and has been fixed by #1464. The fix should be included in superset-ui 0.18.23. |
SUMMARY
This PR adds the ability to reset the forced colors of a namespace. It also returns a fresh new color scale instance every time in order for the ordinal scale to work as intended.
This PR is a prerequisite for the related Superset PR apache/superset#17089
TESTING INSTRUCTIONS
Please follow each test case in the related Superset PR apache/superset#17089
ADDITIONAL INFORMATION
Associated issues: apache/superset#11677 apache/superset#16970 apache/superset#16891 apache/superset#16961 apache/superset#16980 apache/superset#16979