-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy issues, compile target, trace app, add overwrite and debug option #6
Conversation
@mrmckeb could you please test this to see if you get the same error? // package.json
{
"dependencies": {
"@playwright/test": "^1.21.1",
"playwright-merge-html-reports": "nickofthyme/playwright-merge-html-reports#fix-index-issue"
}
} |
@mstepin regarding #3 (comment) I changed the target to |
Thanks. Works in my tests. Will this be merged to the master version soon? |
Not sure, @mrmckeb have you had a chance to test this? |
Thanks, I've tested this today and it's working well for us too - we have two different sets of reports, and I've tested with both. |
Nice! @anooprav7 Could you test this and merge when you get a chance? I removed the build files but you should be able to still test it pointing to 3f86cc4, something like... // package.json
{
"dependencies": {
"@playwright/test": "^1.21.1",
"playwright-merge-html-reports": "nickofthyme/playwright-merge-html-reports#3f86cc47cb2b9bc03159c280763233c29ca1cf3c"
}
} |
I'm not sure what happened, but I'm now able to reproduce the @anooprav7 @nickofthyme to reproduce:
const { mergeHTMLReports } = require("playwright-merge-html-reports");
const inputReportPaths = [
process.cwd() + "/playwright-report-1",
process.cwd() + "/playwright-report-2",
];
const config = {
outputFolderName: "merged-html-report",
};
mergeHTMLReports(inputReportPaths, config);
|
@mrmckeb can you share these two reports so I can test against them directly? Cuz I cannot reproduce this issue on the current example reports. |
This adds the following:
node12
trace/
app to the final merged report only if any of the original reports contain it. All trace.zip
test files were already being copied correctly.debug
option to allow user to control verbosity. (default:false
)overwriteExisting
option to control overwriting existing report. (default:true
)contentFolderPath
when copyingdata/
, it was not joining the src and filename path correctly. See code line diff here.