Resolve module issue and missing data folder

[mrmckeb]

First, thanks for the helpful package!

This PR resolves two issues:

• The data folder may not be present if no screenshots or traces were captured.
• playwright-core may not exist in the specified location. Instead, this package will now find playwright-core directly.

[anooprav7]

LGTM

[mrmckeb]

Thanks @anooprav7 - just a note that this fix was also needed.
#2

We ran into this issue too and I pulled this into my fork, but not the PR I submitted.

[anooprav7]

Ok, checking that now. Thanks

[mstepin]

@anooprav7 I think I'm running described above. I took your 0.2.1 version. It now at least doesn't fail when the folders are missing, but am finding that some tests are missing in the merged report. It also now finds the playwright-core module.
In CI I get a slightly different error though. I've not looked into your code as I haven't had time, but I'm hoping it is related to this. The merged HTML report generated in CI has the index / title page working fine, but clicking into any tests just results in blank pages.

[mrmckeb]

That'll be fixed by this, @mstepin :)
#2

[anooprav7]

#2 has also been merged with #4 (new PR because of merge commits)

[anooprav7]

@mstepin new package version 0.2.2 with the fix merged.

[mstepin]

Hi @anooprav7 thanks for the fix. I tried it today, and at least no tests are missing on the summary. However drilling into tests in a merged report still results in a blank page.

[mstepin]

In addition videos and screenshots are not available on merged reports for failed tests.

EDIT:
seems @nickofthyme 's changes here fixes all the abovementioned issues.

[mrmckeb]

Thanks again for all of your work on this @anooprav7!

[mstepin]

Apologies, I tested the changes locally and they all worked, as I have node 14 locally. This change unfortunately breaks things for us in CI as it makes it no longer node 12 compatible (which is what we have in CI) as it uses ECMA2020 features such as the nullish coalescing syntax ??:

/tmp/jenkins-18f5e62e/workspace/Libraries/pipeline_testing/Pipeline Testing - E2E/e2e/node_modules/playwright-merge-html-reports/dist/merge-reports.js:33
        const [, base64Str] = re.exec(indexHTMLContent) ?? [];

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:1072:16)
    at Module._compile (internal/modules/cjs/loader.js:1122:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/tmp/jenkins-18f5e62e/workspace/Libraries/pipeline_testing/Pipeline Testing - E2E/e2e/lib/helpers/playwrightReportHelper.js:2:30)
    at Module._compile (internal/modules/cjs/loader.js:1158:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
error Command failed with exit code 1.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
script returned exit code 1

[mstepin]

I do appreciate all the work that has gone into this though. Thanks everyone.
I'll look to get the ball rolling to have our CI AMIs baked in with node 14 or higher, once we sift through all the dependencies. Will have to roll back to 0.2.2 for now so it at least doesn't exit the CI flow. If you guys decide to make it node 12 resilient instead, please let me know asap.