-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1305 symmetric decryption #1307
Conversation
Since there is no reliable way to detect which type of message in the provided dictionary, I have nothing to do except add similar methods to |
I agree to create one more PR to actually fully address corresponding issue (I'll reopen it after this PR merged). |
Partially closes ably/docs#1305
ARTMessage
, because of absence of encrypted test data forARTPresenceMessage
. I could use the same file but I'm not sure, lets discuss.fromEncodedJsonArray
omits error while iterating and callingdecodeWithEncoder
for each item, because in the original code (fromARTRestChannel.history
) this error goes nowhere except logger. And in this static function I have no logger, except one I can directly pass intofromEncodedJsonArray
, but that would be in contradiction with spec requirement for this function signature (TM3).