Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct .Net to .NET #1305

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Correct .Net to .NET #1305

merged 1 commit into from
Feb 23, 2022

Conversation

Sapples
Copy link
Contributor

@Sapples Sapples commented Feb 22, 2022

NOTE TO REVIEWERS - please do not review PRs in the DRAFT state, as the PR may change substantially before it is ready to review. Thanks.

Description

Updated all occurrences of .net/.Net/etc to .NET.

Review

As well as updating the textile files I also updated lib/documentation_languages.rb to change the language selector at the top of the pages. As far as I could tell there are no knock on effects from that but please double check as I'm not totally familiar with the infrastructure yet. Happy to remove that change if needed.

Multiple pages throughout, specific example of page requested in initial ticket(select .NET language):

@Sapples Sapples added the DRAFT Draft PR - do not review label Feb 22, 2022
@Sapples Sapples requested a review from m-hulbert February 22, 2022 16:09
@Sapples Sapples self-assigned this Feb 22, 2022
@kennethkalmer kennethkalmer temporarily deployed to ably-docs-doc-613-net-c-nafcrs February 22, 2022 16:10 Inactive
@Sapples Sapples marked this pull request as draft February 22, 2022 16:15
@Sapples Sapples requested a review from tbedford February 22, 2022 16:15
@Sapples Sapples marked this pull request as ready for review February 22, 2022 16:16
Copy link
Contributor

@tbedford tbedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbedford tbedford removed the DRAFT Draft PR - do not review label Feb 22, 2022
@Sapples Sapples merged commit 9c6551a into main Feb 23, 2022
@Sapples Sapples deleted the doc-613-.net-correction branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants