Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nordigen #397

Merged
merged 9 commits into from
Oct 26, 2022
Merged

nordigen #397

merged 9 commits into from
Oct 26, 2022

Conversation

tswfi
Copy link
Member

@tswfi tswfi commented Oct 23, 2022 •
edited
Loading

base for nordigen

settings for client id and key
way to initialize requisition
requisition knows how to fetch transactions

@tswfi tswfi marked this pull request as ready for review October 23, 2022 19:47
@tswfi tswfi requested a review from olmari October 23, 2022 19:47
@tswfi tswfi mentioned this pull request Oct 24, 2022
Closed
janilahti
janilahti approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@janilahti janilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok. When new institutions need to be added at some point, it's best to make it dynamic and update code to read those from the Nordigen api.

@olmari olmari merged commit ec232db into master Oct 26, 2022
@tswfi tswfi deleted the nordigen branch November 1, 2022 18:50
This was referenced Nov 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janilahti janilahti janilahti approved these changes

@olmari olmari Awaiting requested review from olmari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswfi @janilahti @olmari