Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active effects take two #1777

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Active effects take two #1777

merged 16 commits into from
Jan 23, 2025

Conversation

wrycu
Copy link
Collaborator

@wrycu wrycu commented Jan 23, 2025

No description provided.

wrycu added 16 commits January 12, 2025 16:12
* actually gets item attachments working when they are on items
* actually gets mods working when they are on items

#1215
* port changes to armor

#1215
* port changes to vehicle stuff

#1215
* port changes to attachments

#1215
* port changes to specializations

#1215
* add vertical ownership
* correct width of modifications tab

#1215
* update the "configuration" tab icon so it doesn't overlap with "modification" tab
* correct issue where you can't add mods directly to attachments
* correct armor and vehicle mod values
* expand "all" mod values selection

#1215
* make "attributes" the default tab for all sheets which have it

#1215
* correct CSS selector for expanding quality and attachment description

#1215
* fix missing class for qualities from attachments preventing expanding it inline

#1215
* add a warning that changing the attachment or mod "type" will change the values of mods

#1215
* add a note that you can drag-and-drop

#1215
* combine qualities from on-weapon and attachments
* adjust icons
* correct talent submission bug

#1215
* move vehicle weapon price to top row (like weapon price)

#1215
* correct issue with new editor not updating talents
* remove legacy talent-syncing code
* correct "activation" not updating the label on specialization window

#1215
* correct issue where changing any dropdown visually reverts previous changes in the embedded item editor

#1215
@wrycu wrycu merged commit 0c45a11 into main Jan 23, 2025
@wrycu wrycu deleted the active_effects_take_two branch January 23, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant