Enable ActiveEffect support

[wrycu]

The system was designed and built well before ActiveEffects were added to Foundry.

Investigate undoing the custom stuff that's been built and replacing it with ActiveEffects.

I'm not entirely sure what benefits this will bring to the system except that it should simplify the code. This should also be investigated, I suppose.

---

Updated todo list for support:

• basic support for:
  • species
  • itemattachments
  • itemmodifiers
  • weapons
  • armor
  • ship weapons
  • ship attachments
  • talents
  • specializations
  • force powers
  • gear
  • ability?
  • signature ability
  • critical damage
  • critical injury
• Re-introduce restrictions for selected types
• Re-add broken encumbrance and other rule checks
• Update all items to use new UI style for editing embedded items
• Enable support for editing embedded AEs/items
• Resolve TODOs
• Remove console.log()'s
• Improve error handling and user notification
• Refactor new UI to use localization
• Validate that code operates when not set to English
• Refactor to move AE logic into a shared location (e.g. config)
• Look into token status-based AEs
• Handle world migration
• Fix unintentional XSS in new tooltips
• Update chat message to include new information
• Remove new, temporarily-introduced test_itemattachment and test_itemmodifier item types
• Update modifier_type selection to not be dumb on a bunch of items
• Add roll mods?
• Update templates:
  • Ship weapons cannot have attachments

[wrycu]

okay, so far I've got a mod which can contain system-level active effects (VERY WIP UI - basically just enough to let me test functionality)

and I'm playing around with transferring those items to an attachment

next up is:

• modify mods going onto attachments to create a mod note, with a list of effects per mod (instead of only transferring the effects)
• permit creating mods directly from the attachment
• work on creating active effects on items when attachments get dropped on them
• permit defining active effects directly on items

Once these items are done, I'll need to review mods/attachments and see if this is a case where active effects should be pre-defined or custom-defined; how flexible the UI needs to be, etc. After that I'll make a decision around if this is something I can handle or not.

[wrycu]

so, it turns out that step one of my lovely bullet list above is harder than I thought - getFormData or whatever simply returns an array of objects from the form, making it impossible to determine which effects are a part of which mod. I'll think on it some more (likely will need to embed the ID in each input field and customize the function)

[wrycu]

The above commits modifies how attachments are viewed when they're embedded onto a weapon. There are two views. First is a summary view (opened by hovering over the attachment):

and second is a detailed view (opened by hovering over the newly-added question mark on the attachment)

Since this data is now directly embedded onto the weapon, we can no longer easily use the old edit view wherein you click it and it opens the normal attachment window. Instead, clicking the attachment opens a new window:

Saving this submits the data back to the weapon and updates any appropriate ActiveEffects.

NOTE that this functionality is very basic. I made essentially no effort to skin it to look pretty (e.g. the description is a plaintext box instead of a rich text editor) - making it more than barebones functional is a thing for the future.

[wrycu]

I'm taking another shot at this. Any commits after this are a new branch of code, unrelated to the above.

TODO:

• Figure out what modTypeToModMap (in ffg-modifiers.js) should look like
• the mod type "all" should probably actually include all choices, not just... slightly more choices
• setting the mod type to "armor" or "vehicle" seems to generate an error, likely the config is incorrect
• Correct known issues (documented on item-editor.js)
• Review mandar theme edit, which has a fixed height
• Correct width on modifications tab
• Add vertical ownership to modifications in modifications tab
• Figure out where the new view should go on weapons (it's currently in the secondary tab)
• Add expand/collapse all button
• Mod / attachment description click selector is too broad and works on force powers

[wrycu]

Okay, this prework has been done. I'll take a shot at active effects once the work done above has been actually released and confirmed to be working (to minimize untested changes going in at once.)