fix(ui): main menu toggles normally #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tentatively fixes the main menu not being toggled with the escape key, except with a token selected.
Hitting the escape key triggers the first of a bunch of ui changes. The ones that interest us here are:
The group manager/destiny tracker is always open, so "close a window" was always triggered on it, but its close method doesn't actually close it, as it mus remain visible. Instead it contains the main menu toggle code.
No window being actually closed means we stop at "unselect a token" if one is selected, or "toggle the main menu" again if not.
Tentatively because I couldn't find why the main menu toggle code was here, and I'm not sure if I'm not missing something.
Closes #1670