Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): add missing french translations #1678

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

obrenckle
Copy link
Contributor

This PR adds most missing french translations

@wrycu
Copy link
Collaborator

wrycu commented Aug 16, 2024

@obrenckle I know it's annoying but can you please update the changelog to refer to this as well?

@obrenckle
Copy link
Contributor Author

@wrycu Not annoying at all, I'll add it to the changelog, and keep that in mind for future translation work.

What kind of PR update do you prefer in this kind of situations:

  • simple additional commit to the branch
  • amended force-push commit
  • rebased & squashed force pushed commit
  • new PR with a rebased & squashed commit
  • something else

@wrycu
Copy link
Collaborator

wrycu commented Aug 16, 2024

Updating this PR in whatever way you see fit would be nice for me - that way we retain the context.

@obrenckle obrenckle force-pushed the french_translations branch 2 times, most recently from 4423505 to 86fb97b Compare August 16, 2024 21:13
@obrenckle
Copy link
Contributor Author

@wrycu Done.

@obrenckle obrenckle force-pushed the french_translations branch from 86fb97b to fde4119 Compare August 16, 2024 21:16
@obrenckle obrenckle closed this Aug 18, 2024
@obrenckle obrenckle deleted the french_translations branch August 18, 2024 16:35
@obrenckle obrenckle restored the french_translations branch August 18, 2024 16:35
@obrenckle obrenckle reopened this Aug 18, 2024
@wrycu wrycu merged commit ffcb714 into StarWarsFoundryVTT:main Aug 18, 2024
@obrenckle obrenckle deleted the french_translations branch August 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants