-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inquiries API path from /exp to /v1 #4495
Conversation
Looks like I didn't get all of the locations, based on those test failures. Will look at it later. |
Alright, that is much better - all checks passing |
Do we need to leave it |
You thinking about leaving it available at both |
(and yeah, it will break some things when we switch, but...that's the point of |
I think we did this at some point in the whole when we moved something from exp, but I could be wrong. I'm fine with removing it all together as long as it's documented in upgrade notes. |
Related PR: StackStorm/st2#4495
Added Upgrade Notes here StackStorm/st2docs#841 |
Hi, I'm not found /st2client/tests/base.py file, I have the following base.py files:
I use ST2 2.10.0 |
@ivanmpk what is it that you're trying to do? |
Hi I try modify files to inquiry works with environment variable, like this: /~https://github.com/StackStorm/st2/pull/4495/files/b0936677d2cb1e625d5ee57dc252a7b41a85eff2 I use ST2 2.9.2 over OpenShift and API URL is not 127.0.0.1 and when execute st2 inquiry list get connection refused to host 127.0.0.1 |
If you're trying to apply this patch manually on your system, why are you looking for a file named st2client/tests/base.py? I don't see any changes to that file in this PR. It wouldn't matter anyway - the |
Hi @LindsayHill thanks for your quickly answer, I'm not found this file on my system:
I try apply manually this changes on my system. |
You don't need those |
The inquiries API has been moved from `/exp` to `/v1` in StackStorm/st2#4495 Change also needed here in Web UI. Note that default in st2-api module is to use v1 if not otherwise specified.
It's time to move inquries from
/exp
to/api/v1
.API has not changed for months, and we have no short-medium term plans for changing it.
Time to move it to production path, which also resolves issues such as
#4186