Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inquiries API path from /exp to /v1 #4495

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Move inquiries API path from /exp to /v1 #4495

merged 3 commits into from
Jan 15, 2019

Conversation

LindsayHill
Copy link
Contributor

It's time to move inquries from /exp to /api/v1.

API has not changed for months, and we have no short-medium term plans for changing it.

Time to move it to production path, which also resolves issues such as
#4186

@LindsayHill
Copy link
Contributor Author

Looks like I didn't get all of the locations, based on those test failures. Will look at it later.

@LindsayHill
Copy link
Contributor Author

Alright, that is much better - all checks passing

@Kami
Copy link
Member

Kami commented Jan 15, 2019

Do we need to leave it /exp alias there for a while or you think we are fine?

@Kami Kami added this to the 3.0.0 milestone Jan 15, 2019
@Kami Kami added the API label Jan 15, 2019
@LindsayHill
Copy link
Contributor Author

You thinking about leaving it available at both /exp and /v1? Not sure if we can do that easily?

@LindsayHill
Copy link
Contributor Author

(and yeah, it will break some things when we switch, but...that's the point of /exp, right?

@Kami
Copy link
Member

Kami commented Jan 15, 2019

I think we did this at some point in the whole when we moved something from exp, but I could be wrong.

I'm fine with removing it all together as long as it's documented in upgrade notes.

LindsayHill added a commit to StackStorm/st2docs that referenced this pull request Jan 15, 2019
@LindsayHill
Copy link
Contributor Author

Added Upgrade Notes here StackStorm/st2docs#841

@ivanmpk
Copy link

ivanmpk commented Feb 6, 2019

Hi, I'm not found /st2client/tests/base.py file, I have the following base.py files:

/opt/stackstorm/st2/lib/python2.7/site-packages/st2api/controllers/base.py
/opt/stackstorm/st2/lib/python2.7/site-packages/st2tests/base.py

I use ST2 2.10.0

@LindsayHill
Copy link
Contributor Author

@ivanmpk what is it that you're trying to do?

@ivanmpk
Copy link

ivanmpk commented Feb 7, 2019

Hi I try modify files to inquiry works with environment variable, like this:

/~https://github.com/StackStorm/st2/pull/4495/files/b0936677d2cb1e625d5ee57dc252a7b41a85eff2

I use ST2 2.9.2 over OpenShift and API URL is not 127.0.0.1 and when execute st2 inquiry list get connection refused to host 127.0.0.1

@LindsayHill
Copy link
Contributor Author

If you're trying to apply this patch manually on your system, why are you looking for a file named st2client/tests/base.py? I don't see any changes to that file in this PR.

It wouldn't matter anyway - the tests content is for unit tests. Are you trying to run those unit tests on your system? Or are you just trying to manually apply the actual code changes to your system?

@ivanmpk
Copy link

ivanmpk commented Feb 7, 2019

Hi @LindsayHill thanks for your quickly answer, I'm not found this file on my system:

/~https://github.com/StackStorm/st2/blob/b0936677d2cb1e625d5ee57dc252a7b41a85eff2/st2api/tests/base.py

I try apply manually this changes on my system.

@LindsayHill
Copy link
Contributor Author

You don't need those /tests directories on a running system. Those are unit tests.

LindsayHill added a commit to StackStorm/st2web that referenced this pull request Feb 13, 2019
The inquiries API has been moved from `/exp` to `/v1` in StackStorm/st2#4495

Change also needed here in Web UI. Note that default in st2-api module is to use v1 if not otherwise specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants