Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inquiries API path from /exp to /v1 #4495

Merged
merged 3 commits into from
Jan 15, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ Added

Contributed by Hiroyasu OHYAMA (@userlocalhost).

Changed
~~~~~~~

* Changed the ``inquiries`` API path from ``/exp`` to ``/api/v1`` #4495

2.10.0 - December 13, 2018
--------------------------

Expand Down
6 changes: 3 additions & 3 deletions st2api/tests/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,17 +256,17 @@ def _do_get_execution(self, actionexecution_id, *args, **kwargs):
return self.app.get('/v1/executions/%s' % actionexecution_id, *args, **kwargs)

def _do_get_one(self, inquiry_id, *args, **kwargs):
return self.app.get('/exp/inquiries/%s' % inquiry_id, *args, **kwargs)
return self.app.get('/v1/inquiries/%s' % inquiry_id, *args, **kwargs)

def _do_get_all(self, limit=50, *args, **kwargs):
return self.app.get('/exp/inquiries/?limit=%s' % limit, *args, **kwargs)
return self.app.get('/v1/inquiries/?limit=%s' % limit, *args, **kwargs)

def _do_respond(self, inquiry_id, response, *args, **kwargs):
payload = {
"id": inquiry_id,
"response": response
}
return self.app.put_json('/exp/inquiries/%s' % inquiry_id, payload, *args, **kwargs)
return self.app.put_json('/v1/inquiries/%s' % inquiry_id, payload, *args, **kwargs)

def _do_create_inquiry(self, liveaction, result, status='pending', *args, **kwargs):
post_resp = self.app.post_json('/v1/executions', liveaction, *args, **kwargs)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from six.moves import http_client

from st2common.transport.publishers import PoolPublisher
from st2api.controllers.exp.inquiries import InquiriesController
from st2api.controllers.v1.inquiries import InquiriesController
from st2common.constants import action as action_constants
from st2common import log as logging
import st2common.validators.api.action as action_validator
Expand Down Expand Up @@ -166,7 +166,7 @@
@mock.patch.object(PoolPublisher, 'publish', mock.MagicMock())
class InquiryControllerTestCase(BaseInquiryControllerTestCase,
APIControllerWithIncludeAndExcludeFilterTestCase):
get_all_path = '/exp/inquiries'
get_all_path = '/v1/inquiries'
controller_cls = InquiriesController
include_attribute_field_name = 'ttl'
exclude_attribute_field_name = 'ttl'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from st2tests import fixturesloader

from tests import base as api_tests_base
from tests.unit.controllers.exp import test_inquiries
from tests.unit.controllers.v1 import test_inquiries


SCHEMA_DEFAULT = copy.deepcopy(test_inquiries.SCHEMA_DEFAULT)
Expand Down
2 changes: 1 addition & 1 deletion st2client/st2client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def __init__(self, base_url=None, auth_url=None, api_url=None, stream_url=None,
# backward compatibility reasons until v3.2.0
self.managers['LiveAction'] = self.managers['Execution']
self.managers['Inquiry'] = InquiryResourceManager(
models.Inquiry, self.endpoints['exp'], cacert=self.cacert, debug=self.debug)
models.Inquiry, self.endpoints['api'], cacert=self.cacert, debug=self.debug)
self.managers['Pack'] = PackResourceManager(
models.Pack, self.endpoints['api'], cacert=self.cacert, debug=self.debug)
self.managers['Policy'] = ResourceManager(
Expand Down
10 changes: 5 additions & 5 deletions st2common/st2common/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1361,9 +1361,9 @@ paths:
description: Unexpected error
schema:
$ref: '#/definitions/Error'
/api/exp/inquiries:
/api/v1/inquiries:
get:
operationId: st2api.controllers.exp.inquiries:inquiries_controller.get_all
operationId: st2api.controllers.v1.inquiries:inquiries_controller.get_all
x-permissions: inquiry_list
description: Returns a list of all inquiries
parameters:
Expand Down Expand Up @@ -1401,9 +1401,9 @@ paths:
description: Unexpected error
schema:
$ref: '#/definitions/Error'
/api/exp/inquiries/{inquiry_id}:
/api/v1/inquiries/{inquiry_id}:
get:
operationId: st2api.controllers.exp.inquiries:inquiries_controller.get_one
operationId: st2api.controllers.v1.inquiries:inquiries_controller.get_one
description: |
Get a specific Inquiry based on ID.
parameters:
Expand All @@ -1427,7 +1427,7 @@ paths:
schema:
$ref: '#/definitions/Error'
put:
operationId: st2api.controllers.exp.inquiries:inquiries_controller.put
operationId: st2api.controllers.v1.inquiries:inquiries_controller.put
description: |
Respond to an Inquiry.
parameters:
Expand Down
10 changes: 5 additions & 5 deletions st2common/st2common/openapi.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -1357,9 +1357,9 @@ paths:
description: Unexpected error
schema:
$ref: '#/definitions/Error'
/api/exp/inquiries:
/api/v1/inquiries:
get:
operationId: st2api.controllers.exp.inquiries:inquiries_controller.get_all
operationId: st2api.controllers.v1.inquiries:inquiries_controller.get_all
x-permissions: {{ PERMISSION_TYPE.INQUIRY_LIST }}
description: Returns a list of all inquiries
parameters:
Expand Down Expand Up @@ -1397,9 +1397,9 @@ paths:
description: Unexpected error
schema:
$ref: '#/definitions/Error'
/api/exp/inquiries/{inquiry_id}:
/api/v1/inquiries/{inquiry_id}:
get:
operationId: st2api.controllers.exp.inquiries:inquiries_controller.get_one
operationId: st2api.controllers.v1.inquiries:inquiries_controller.get_one
description: |
Get a specific Inquiry based on ID.
parameters:
Expand All @@ -1423,7 +1423,7 @@ paths:
schema:
$ref: '#/definitions/Error'
put:
operationId: st2api.controllers.exp.inquiries:inquiries_controller.put
operationId: st2api.controllers.v1.inquiries:inquiries_controller.put
description: |
Respond to an Inquiry.
parameters:
Expand Down