Add support for templating in init-container #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2019 16:32
shaikatz
reviewed
May 27, 2019
| ``` | ||
| 5. Now you can run the init container: | ||
| ``` | ||
| node index.js -e encrypted -d decrypted -n output.json |
There was a problem hiding this comment.
Explain what is encrypted ? is a folder? is it a file?
There was a problem hiding this comment.
it's a folder - I put it there with some ready-made encrypted content that is ready for debugging
There was a problem hiding this comment.
I mean, it needs to be more clear in the MD.
shaikatz
reviewed
May 27, 2019
| ``` | ||
| { | ||
| "secrets": [] //array of the decretyped items, key value pairs. |
There was a problem hiding this comment.
Unclear what is the template input is ?
shaikatz
previously approved these changes
May 27, 2019
shaikatz
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #141 #202