Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml support to init container #141

Closed
yaron-idan opened this issue Apr 7, 2019 · 2 comments · Fixed by #204
Closed

Add yaml support to init container #141

yaron-idan opened this issue Apr 7, 2019 · 2 comments · Fixed by #204
Assignees

Comments

@yaron-idan
Copy link
Contributor

yaron-idan commented Apr 7, 2019

Generating yaml configurations is becoming popular, in my case I found the need for it because that is the format rtmbot is expecting.

Adding support for this in Kamus can ease onboarding for many services, so I'll open a PR for it.
WDYT?

@yaron-idan yaron-idan self-assigned this Apr 7, 2019
@yaron-idan
Copy link
Contributor Author

After some work, it seems supporting yaml for secrets encryption could miss some of the advantages of the format, since kubernetes configmaps cannot handle arrays or nested objects.
A better approach might be allowing users to supply Kamus with a template file.
This feature should include -

  • Adding a template option to the kamus cli
  • Setting a clear standard for kamus secret placeholders in the template
  • Allowing the init container to inject secrets into the template
    WDYT @omerlh ?

@omerlh
Copy link
Contributor

omerlh commented Apr 7, 2019

Sounds interesting - maybe as a refactoring of the current init container, with JSON as a template and allowing user-supplied template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants