Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Fabric React Native 0.70 #937

Closed
wants to merge 4 commits into from
Closed

Conversation

chrfalch
Copy link
Contributor

Added support for Fabric (and paper at the same time) for iOS on top of RN 0.70.0.

Based on #936

Resolves #387

@chrfalch chrfalch requested a review from wcandillon September 16, 2022 12:17
@SVossMcK
Copy link

Is there any way that I can help with this migration? We are really hoping to use this library but are constrained to the new architecture by a client of ours with a deadline fast approaching. I'm happy to help out how I can so you can finalize this migration.

@chrfalch
Copy link
Contributor Author

Is there any way that I can help with this migration? We are really hoping to use this library but are constrained to the new architecture by a client of ours with a deadline fast approaching. I'm happy to help out how I can so you can finalize this migration.

Thanks for suggesting to help - the reason for postponing this has been the changes in the latest releases of React Native where the conversion has become much simpler. Our requirement is to support both the old and the new architecture - and if you want to help we'd be super happy with a PR based on the latest 0.70 version of React Native. Otherwise we expect to continue working on the conversion in the end of November / beginning of December.

@JohnathanWhite
Copy link

hey @chrfalch! are there any updates on support for the new architecture?

@numandev1
Copy link

Any update?

@skurgansky-sugarcrm
Copy link

looks like it's expo only lib

@@ -4,6 +4,8 @@ require "json"

package = JSON.parse(File.read(File.join(__dir__, "package.json")))

fabric_enabled = ENV['RCT_NEW_ARCH_ENABLED']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be like this fabric_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1' otherwise there will be no way for disable it

@numandev1
Copy link

numandev1 commented Jul 4, 2023

I am using this fabric changes like this in my app

"@shopify/react-native-skia": "/~https://github.com/numandev1/react-native-skia-fabric#main",

@numandev1
Copy link

@wcandillon is there any plan to merge it?

@Daavidaviid
Copy link

I am using this fabric changes like this in my app

"@shopify/react-native-skia": "/~https://github.com/numandev1/react-native-skia-fabric#main",

I'm using this for now. What files did you change exactly ?

@kiril-me
Copy link

kiril-me commented Nov 3, 2023

any plans to finish the work?

@jahead
Copy link
Contributor

jahead commented Nov 6, 2023

it would be awesome to rebase this on main, as the android changes are required to make this work with 0.73.0

@wcandillon
Copy link
Contributor

We are closing this in favor of #1961
Huge thank you to @WoLewicki ❤️

@wcandillon wcandillon closed this Nov 7, 2023
@wcandillon wcandillon deleted the feature/387-ios-fabric-rn-0.70 branch December 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Add support for Fabric / new architecture
9 participants