-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Fabric React Native 0.70 #937
Conversation
Is there any way that I can help with this migration? We are really hoping to use this library but are constrained to the new architecture by a client of ours with a deadline fast approaching. I'm happy to help out how I can so you can finalize this migration. |
Thanks for suggesting to help - the reason for postponing this has been the changes in the latest releases of React Native where the conversion has become much simpler. Our requirement is to support both the old and the new architecture - and if you want to help we'd be super happy with a PR based on the latest 0.70 version of React Native. Otherwise we expect to continue working on the conversion in the end of November / beginning of December. |
hey @chrfalch! are there any updates on support for the new architecture? |
Any update? |
looks like it's expo only lib |
@@ -4,6 +4,8 @@ require "json" | |||
|
|||
package = JSON.parse(File.read(File.join(__dir__, "package.json"))) | |||
|
|||
fabric_enabled = ENV['RCT_NEW_ARCH_ENABLED'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be like this fabric_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1'
otherwise there will be no way for disable it
I am using this fabric changes like this in my app
|
@wcandillon is there any plan to merge it? |
I'm using this for now. What files did you change exactly ? |
any plans to finish the work? |
it would be awesome to rebase this on main, as the android changes are required to make this work with 0.73.0 |
We are closing this in favor of #1961 |
Added support for Fabric (and paper at the same time) for iOS on top of RN 0.70.0.
Based on #936
Resolves #387