feat: support new arch #1961
Merged
feat: support new arch #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
wcandillon
reviewed
Nov 7, 2023
| @@ -1,6 +1,11 @@ | |||
| #pragma once | |||
|
|
|||
| #ifdef TARGET_OS_IPHONE | |||
| #include <react-native-skia/ImageProps.h> | |||
| #else | |||
| #include "ImageProps.h" | |||
wcandillon
reviewed
Nov 7, 2023
| @@ -0,0 +1,79 @@ | |||
| This is a new [**React Native**](https://reactnative.dev) project, bootstrapped using [`@react-native-community/cli`](/~https://github.com/react-native-community/cli). | |||
|
|
|||
There was a problem hiding this comment.
Needs to be added to yarn bootstrap, also we need to add it to CI. Add pod install to postinstall on both example and fabricexample
wcandillon
reviewed
Nov 8, 2023
| @@ -0,0 +1,8 @@ | |||
| import type { TurboModule } from "react-native/Libraries/TurboModule/RCTExport"; | |||
| import { TurboModuleRegistry } from "react-native"; | |||
There was a problem hiding this comment.
here we probably want to use to use platform (Platform is what we use to "polyfill" react native API on web without the need to use react-native-web)
|
I have signed the CLA! |
|
You can test the RN Skia on Fabric with this test package: https://bit.ly/shopify-react-native-skia-fabric |
|
I get this error testing it with the RNSkia hello world:
|
…wicki/react-native-skia into @wolewicki/new-arch-support
wcandillon
reviewed
Nov 10, 2023
wcandillon
reviewed
Nov 10, 2023
wcandillon
approved these changes
Nov 10, 2023
|
@WoLewicki congrats 🥂🙌🏼 and a big thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adding support for new architecture and adding
fabricexampleapp where it can be tested.Test package: https://bit.ly/shopify-react-native-skia-fabric
fixes #387
fixes #676