Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded example project to React Native 0.70.1 #936

Merged
merged 11 commits into from
Sep 27, 2022
Merged

Upgraded example project to React Native 0.70.1 #936

merged 11 commits into from
Sep 27, 2022

Conversation

chrfalch
Copy link
Contributor

Upgraded Example project to React Native 0.70.0

Tested and verified that iOS/Android/Web works

Fixes #721

@chrfalch chrfalch requested a review from wcandillon September 16, 2022 08:39
@chrfalch chrfalch mentioned this pull request Sep 16, 2022
Closed
@wcandillon
Copy link
Contributor

I've been having a couple of issues to make the build work on Android maybe we can take this offline.

@chrfalch chrfalch changed the title Upgraded example project to React Native 0.70.0 Upgraded example project to React Native 0.70.1 Sep 27, 2022
@chrfalch
Copy link
Contributor Author

I've been having a couple of issues to make the build work on Android maybe we can take this offline.

Fixed Android issues and upgraded everything to 0.70.1. The problem was that we were still using RN 0.66 in our library (dev dependencies) so for us (library developers) we got some strange errors that are now solved. Retested on both Android/iOS.

@wcandillon
Copy link
Contributor

Works great, can you update the podfile lock and we can merge it?

wcandillon
wcandillon requested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update podfile lock 👍🏻

@chrfalch
Copy link
Contributor Author

Update podfile lock 👍🏻

Podfile.lock is updated? - something specific that is missing? I'm running pod install on my side and there are now no changes to the Podfile.lock.

@wcandillon
Copy link
Contributor

I'm seeing the following diff:

-  - hermes-engine (0.70.0)
+  - hermes-engine (0.70.1)
   - libevent (2.1.12)
   - OpenSSL-Universal (1.1.1100)
   - RCT-Folly (2021.07.22.00):
@@ -616,7 +616,7 @@ SPEC CHECKSUMS:
   FlipperKit: cbdee19bdd4e7f05472a66ce290f1b729ba3cb86
   fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
   glog: 476ee3e89abb49e07f822b48323c51c57124b572
-  hermes-engine: 8e84f1284180801c1a1b241f443ba64f931ff561
+  hermes-engine: 9cd393f741bfa14d1d0cd90cc373e3619c0bc7ea

@chrfalch
Copy link
Contributor Author

I'm seeing the following diff:

-  - hermes-engine (0.70.0)
+  - hermes-engine (0.70.1)
   - libevent (2.1.12)
   - OpenSSL-Universal (1.1.1100)
   - RCT-Folly (2021.07.22.00):
@@ -616,7 +616,7 @@ SPEC CHECKSUMS:
   FlipperKit: cbdee19bdd4e7f05472a66ce290f1b729ba3cb86
   fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
   glog: 476ee3e89abb49e07f822b48323c51c57124b572
-  hermes-engine: 8e84f1284180801c1a1b241f443ba64f931ff561
+  hermes-engine: 9cd393f741bfa14d1d0cd90cc373e3619c0bc7ea

Ah, nice catch - I had to remove the iOS/Pods folder..!

@wcandillon wcandillon self-requested a review September 27, 2022 09:54
@wcandillon wcandillon merged commit d6666c9 into main Sep 27, 2022
@chrfalch chrfalch deleted the feature/721-upgrade-example-0.70.0 branch September 27, 2022 11:02
@wcandillon wcandillon mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcandillon wcandillon wcandillon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade example project to React-Native 0.70.0
2 participants
@chrfalch @wcandillon