Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Modal): update props' description #4291

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

bonellia
Copy link
Contributor

@bonellia bonellia commented Oct 6, 2021

I suppose Modal is just a specialized Portal (or vice-versa?) but I suppose props docs for modal could be less ambiguous with these small changes.

I suppose Modal is just a specialized Portal (or vice-versa?) but I suppose props docs for modal could be less ambiguous with these small changes.
@welcome
Copy link

welcome bot commented Oct 6, 2021

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #4291 (e09c9e7) into master (848f497) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4291   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3241     3241           
=======================================
  Hits         3233     3233           
  Misses          8        8           
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848f497...e09c9e7. Read the comment docs.

@layershifter layershifter changed the title Update Modal.js docs(Modal): update props' description Jan 14, 2022
@welcome
Copy link

welcome bot commented Jan 14, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants