Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Modal): update props' description #4291

Merged
merged 3 commits into from
Jan 14, 2022
Merged

docs(Modal): update props' description #4291

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c9a721
Update Modal.js
bonellia Oct 6, 2021
13c9011
Merge branch 'master' into patch-1
layershifter Jan 14, 2022
e09c9e7
Update src/modules/Modal/Modal.js
layershifter Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/modules/Modal/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ Modal.propTypes = {
onClose: PropTypes.func,

/**
* Called when the portal is mounted on the DOM.
* Called when the modal is mounted on the DOM.
*
* @param {null}
* @param {object} data - All props.
Expand All @@ -357,7 +357,7 @@ Modal.propTypes = {
onOpen: PropTypes.func,

/**
* Called when the portal is unmounted from the DOM.
* Called when the modal is unmounted from the DOM.
*
* @param {null}
* @param {object} data - All props.
Expand All @@ -373,12 +373,12 @@ Modal.propTypes = {
/** Custom styles. */
style: PropTypes.object,

/** Element to be rendered in-place where the portal is defined. */
/** Element to be rendered in-place where the modal is defined. */
trigger: PropTypes.node,

/**
* NOTE: Any unhandled props that are defined in Portal are passed-through
* to the wrapping Portal.
* NOTE: Any unhandled props that are defined in Modal are passed-through
* to the wrapping Modal.
layershifter marked this conversation as resolved.
Show resolved Hide resolved
*/
}

Expand Down