Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve CodeSandbox integration #4010

Merged
merged 1 commit into from
Jul 30, 2020
Merged

docs: improve CodeSandbox integration #4010

merged 1 commit into from
Jul 30, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 30, 2020

Fixed bug 🐛

Fixes #3927. For some reason previously we got "https://react.semantic-ui.comhttps://react.semantic-ui.com" on CodeSandbox.

Update CodeSandbox icon

Previous icon was not correct which may confuse people.

image
👇
image

Integration improvements

  • only required dependencies will added to package.json as not all examples use lodash for example
  • range of dependencies will be now the same as in our package.json, semantic-ui-react's version will be the same as the current version of doc site

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 70.84 KB (0%)
bundle-size/dist/Icon.size.js 33.41 KB (0%)
bundle-size/dist/Image.size.js 66.13 KB (0%)
bundle-size/dist/Portal.size.js 49.9 KB (0%)

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #4010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4010   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         185      185           
  Lines        3251     3251           
=======================================
  Hits         3246     3246           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5532548...080a37e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken example in codesandbox.io for Ribbon Label Type example
2 participants