Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken example in codesandbox.io for Ribbon Label Type example #3927

Closed
gregfenton opened this issue Apr 6, 2020 · 4 comments · Fixed by #4010
Closed

Broken example in codesandbox.io for Ribbon Label Type example #3927

gregfenton opened this issue Apr 6, 2020 · 4 comments · Fixed by #4010
Labels

Comments

@gregfenton
Copy link

Bug Report

Steps

  1. Go to documentation for Ribbon type labels
  2. Click the CodeSandbox link in the top-right corner of the examples segment
  3. When the checkmark appears, click it to be taken to CodeSandbox
  4. When CodeSandbox loads, notice that the URLs for the tags have doubled the URL prefix so they are: <Image src='https://react.semantic-ui.comhttps://react.semantic-ui.com/images/wireframe/paragraph.png' />
    (NOTE: the double https:// prefix, making the image source URL invalid)

Expected Result

CodeSandbox opens with a working example.

Actual Result

CodeSandbox opens with broken images.

Version

Currently published docs on 2020/04/06.

Testcase

@welcome
Copy link

welcome bot commented Apr 6, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@gregfenton gregfenton changed the title URL Prefix doubled up in codesandbox.io for Ribbon Label Type example Broken example in codesandbox.io for Ribbon Label Type example Apr 6, 2020
@JayeshJanyani
Copy link

Hi @gregfenton, did you report a bug for the same.
If it is not closed, Please share the bug number.

@gregfenton
Copy link
Author

This was my bug report.

@layershifter
Copy link
Member

layershifter commented Jul 30, 2020

@gregfenton thanks for reporting. I also noticed the same issue 🐛

Fixed in #4010 and will be deployed with the next SUIR version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants