Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EventStack): fix issues with event handling #3148

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 11, 2018

Fixes #3006.
Fixes #3062.

WIP

Details: #3124 (comment)

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b75cc96). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3148   +/-   ##
=========================================
  Coverage          ?   99.92%           
=========================================
  Files             ?      163           
  Lines             ?     2746           
  Branches          ?        0           
=========================================
  Hits              ?     2744           
  Misses            ?        2           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75cc96...a02adb5. Read the comment docs.

@levithomason levithomason merged commit 2907a26 into master Sep 12, 2018
@levithomason levithomason deleted the fix/eventstack branch September 12, 2018 23:33
@annjawn
Copy link

annjawn commented Sep 13, 2018

Beautiful. I can confirm that this has resolved the issue will dropdown too as reported in #3062

@lucmerceron
Copy link

Hello guys,
I just updated and the bug is still present for me. Tested on sandbox and in the official storybook

@layershifter
Copy link
Member Author

@lucmerceron I've reopen #3006, @levithomason merged this PR too early 😸 Still working on it

@annjawn
Copy link

annjawn commented Sep 13, 2018

Interesting. However, so far the dropdown issue looks to have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants