Skip to content

Commit

Permalink
fix(EventStack): fix issues with event handling (#3148)
Browse files Browse the repository at this point in the history
  • Loading branch information
@layershifter @levithomason
layershifter authored and levithomason committed Sep 12, 2018
1 parent b75cc96 commit 2907a26
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"homepage": "/~https://github.com/Semantic-Org/Semantic-UI-React#readme",
"dependencies": {
"@babel/runtime": "^7.0.0",
"@semantic-ui-react/event-stack": "^1.0.2",
"@semantic-ui-react/event-stack": "^2.0.0",
"classnames": "^2.2.6",
"keyboard-key": "^1.0.2",
"lodash": "^4.17.10",
Expand Down
4 changes: 2 additions & 2 deletions src/lib/eventStack/index.js
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import eventStack from '@semantic-ui-react/event-stack'
import { instance } from '@semantic-ui-react/event-stack'

This comment has been minimized.

Sign in to view

Copy link
@sholladay

sholladay Sep 13, 2018

This is breaking for me. Will file an issue when I have a bit more time.

Error: 'instance' is not exported by node_modules/@semantic-ui-react/event-stack/lib/index.js
    at error (/home/circleci/repo/node_modules/rollup/dist/rollup.js:3438:30)
    at Module.error (/home/circleci/repo/node_modules/rollup/dist/rollup.js:13342:9)
    at handleMissingExport (/home/circleci/repo/node_modules/rollup/dist/rollup.js:13029:21)
    at Module.traceVariable (/home/circleci/repo/node_modules/rollup/dist/rollup.js:13450:17)
    at ModuleScope.findVariable (/home/circleci/repo/node_modules/rollup/dist/rollup.js:12709:29)
    at Identifier$$1.bind (/home/circleci/repo/node_modules/rollup/dist/rollup.js:9649:40)
    at ExportDefaultDeclaration$$1.NodeBase.bind (/home/circleci/repo/node_modules/rollup/dist/rollup.js:9161:23)
    at ExportDefaultDeclaration$$1.bind (/home/circleci/repo/node_modules/rollup/dist/rollup.js:9788:31)
    at Program.NodeBase.bind (/home/circleci/repo/node_modules/rollup/dist/rollup.js:9157:31)
    at Module.bindReferences (/home/circleci/repo/node_modules/rollup/dist/rollup.js:13296:18)

export default eventStack
export default instance
7 changes: 4 additions & 3 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -789,11 +789,12 @@
dependencies:
any-observable "^0.3.0"

"@semantic-ui-react/event-stack@^1.0.2":
version "1.0.2"
resolved "https://registry.yarnpkg.com/@semantic-ui-react/event-stack/-/event-stack-1.0.2.tgz#af54da94daaba2cec108f54f57a437ae495ddabe"
"@semantic-ui-react/event-stack@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@semantic-ui-react/event-stack/-/event-stack-2.0.0.tgz#d2d568a9fb0ee204b0e40d6b73ac2a2403c08451"
dependencies:
exenv "^1.2.2"
prop-types "^15.6.2"

"@sinonjs/commons@^1.0.2":
version "1.0.2"
Expand Down

0 comments on commit 2907a26

Please sign in to comment.