fix(examples): fix in webpack3 examples #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Feb 22, 2018
| } | ||
| ]}], | ||
| "lodash" | ||
| ["lodash", {"id": ["lodash", "semantic-ui-react"]}] |
There was a problem hiding this comment.
babel-plugin-direct-import seems doesn't work at all 😞 Replaced with babel-plugin-lodash
layershifter
commented
Feb 22, 2018
| @@ -7,34 +7,39 @@ | |||
| "react": "^16.2.0", | |||
| "react-dom": "^16.2.0", | |||
| "semantic-ui-less": "^2.2.12", | |||
| "semantic-ui-react": "^0.77.0" | |||
| "semantic-ui-react": "^0.78.2" | |||
There was a problem hiding this comment.
Updated to latest SUIR 👍
layershifter
commented
Feb 22, 2018
| "webpack-bundle-analyzer": "^2.10.0", | ||
| "webpack-dev-server": "^2.11.1", | ||
| "webpack-manifest-plugin": "^1.3.2", | ||
| "webpack-merge": "^4.1.1" |
There was a problem hiding this comment.
Added missing deps and updated existing
layershifter
commented
Feb 22, 2018
| @@ -1,5 +1,5 @@ | |||
| @import '~heading.less'; | |||
|
|
|||
| .container { | |||
| margin-top: @relative64px; | |||
| padding-top: @relative64px; | |||
There was a problem hiding this comment.
Wrong top there was ⭐
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 160 160
Lines 2744 2744
=======================================
Hits 2737 2737
Misses 7 7Continue to review full report at Codecov.
|
|
Tested locally, everything works as expected 👍 Merged |
|
Thanks for the fix!!! |
|
Released in |
Brantron
pushed a commit
to Brantron/Semantic-UI-React
that referenced
this pull request
Mar 14, 2018
bmbarker90
added a commit
to bmbarker90/Semantic-UI-React
that referenced
this pull request
Jun 20, 2018
It appears that in Semantic-Org#2561 the decision was made to switch to using babel-plugin-lodash, but the description of how direct imports are handled was not updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2559.