Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix in webpack3 examples #2561

Merged
merged 1 commit into from
Feb 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions examples/webpack3/.babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,7 @@
"plugins": [
"@babel/plugin-proposal-class-properties",
"@babel/plugin-proposal-export-default-from",
["direct-import", { "modules": [
"semantic-ui-react", {
"name": "semantic-ui-react",
"indexFile": "semantic-ui-react/dist/es/index.js"
}
]}],
"lodash"
["lodash", {"id": ["lodash", "semantic-ui-react"]}]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel-plugin-direct-import seems doesn't work at all 😞 Replaced with babel-plugin-lodash

],
"env": {
"development": {
Expand Down
53 changes: 29 additions & 24 deletions examples/webpack3/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,39 @@
"react": "^16.2.0",
"react-dom": "^16.2.0",
"semantic-ui-less": "^2.2.12",
"semantic-ui-react": "^0.77.0"
"semantic-ui-react": "^0.78.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to latest SUIR 👍

},
"devDependencies": {
"@babel/core": "^7.0.0-beta.34",
"@babel/preset-env": "^7.0.0-beta.34",
"autoprefixer": "7.1.6",
"babel-loader": "8.0.0-beta.0",
"@babel/core": "^7.0.0-beta.40",
"@babel/plugin-proposal-class-properties": "^7.0.0-beta.40",
"@babel/plugin-proposal-export-default-from": "^7.0.0-beta.40",
"@babel/preset-env": "^7.0.0-beta.40",
"@babel/preset-react": "^7.0.0-beta.40",
"autoprefixer": "^8.0.0",
"babel-loader": "^8.0.0-beta.0",
"babel-plugin-lodash": "^3.3.2",
"babel-plugin-transform-react-remove-prop-types": "^0.4.10",
"case-sensitive-paths-webpack-plugin": "2.1.1",
"chalk": "1.1.3",
"cross-env": "^5.1.1",
"css-loader": "0.28.7",
"extract-text-webpack-plugin": "3.0.2",
"file-loader": "1.1.5",
"fs-extra": "3.0.1",
"html-webpack-plugin": "2.29.0",
"babel-plugin-transform-react-remove-prop-types": "^0.4.13",
"case-sensitive-paths-webpack-plugin": "^2.1.1",
"chalk": "^2.3.1",
"cross-env": "^5.1.3",
"css-loader": "^0.28.10",
"extract-text-webpack-plugin": "^3.0.2",
"file-loader": "^1.1.9",
"fs-extra": "^5.0.0",
"html-webpack-plugin": "2.30.1",
"less": "^2.7.2",
"less-loader": "^4.0.5",
"postcss-flexbugs-fixes": "3.2.0",
"postcss-loader": "2.0.8",
"react-dev-utils": "^4.2.1",
"style-loader": "0.19.0",
"uglifyjs-webpack-plugin": "^1.1.2",
"url-loader": "0.6.2",
"webpack": "3.8.1",
"webpack-bundle-analyzer": "^2.9.1",
"webpack-dev-server": "2.9.4",
"webpack-manifest-plugin": "1.3.2"
"postcss-flexbugs-fixes": "^3.3.0",
"postcss-loader": "^2.1.0",
"react-dev-utils": "^5.0.0",
"style-loader": "^0.20.2",
"uglifyjs-webpack-plugin": "^1.2.0",
"url-loader": "^0.6.2",
"webpack": "^3.11.0",
"webpack-bundle-analyzer": "^2.10.0",
"webpack-dev-server": "^2.11.1",
"webpack-manifest-plugin": "^1.3.2",
"webpack-merge": "^4.1.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing deps and updated existing

},
"scripts": {
"start": "node scripts/start.js",
Expand Down
2 changes: 0 additions & 2 deletions examples/webpack3/scripts/build.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


// Do this as the first thing so that any code reading it knows the right env.
process.env.BABEL_ENV = 'production'
process.env.NODE_ENV = 'production'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '~heading.less';

.container {
margin-top: @relative64px;
padding-top: @relative64px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong top there was ⭐

}
Loading