Adding ros param to use different config files #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We would like to have this change because we have all our robot-specific config files in a different package than the drivers. |
|
We have merged your PR to the dev branch. Thanks to everyone. |
|
close the PR. |
robertkurvits
pushed a commit
to DUT-Racing/rslidar_sdk
that referenced
this pull request
Feb 14, 2023
…tion Fix/fake perception
robertkurvits
pushed a commit
to DUT-Racing/rslidar_sdk
that referenced
this pull request
Feb 14, 2023
…ompile Fix/robosense compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the current version of the driver works with a fixed config file located in config/config.yaml inside the project folder.
This is quite inconvenient if we want to use the same driver with different sensors setups with configuration files located on other folders.
This pull request applies a modification to be able to set the config file as a ROS parameter.
The modication works with ROS (not ROS2)