Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS1 and ROS2 Config param #52

Closed
wants to merge 2 commits into from
Closed

ROS1 and ROS2 Config param #52

wants to merge 2 commits into from

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Jul 23, 2021

Add ROS2 parameter on top of #39

Thanks @mtlazaro for the initial part!

@Timple
Copy link
Contributor Author

Timple commented Aug 10, 2021

Can I get any comment on this PR?

@Timple Timple mentioned this pull request Jan 3, 2022
Open
@ronzheng1006
Copy link
Contributor

We have merged your PR to the dev branch. Thank you.

@Timple
Copy link
Contributor Author

Timple commented Jan 12, 2022

Great!

As nobody seems to be watching the rslidar_msg repository. A subtle ping here for a PR there: RoboSense-LiDAR/rslidar_msg#1

@Timple
Copy link
Contributor Author

Timple commented Jan 20, 2022

Merged in dev

@Timple Timple closed this Jan 20, 2022
@Timple
Copy link
Contributor Author

Timple commented Feb 11, 2022

For future readers: Turns out they didn't use the parameter rslidar_config_file but modified it to config_path

@Timple Timple mentioned this pull request Sep 12, 2022
Merged
@Timple
Copy link
Contributor Author

Timple commented Sep 12, 2022

Turns out this wasn't merged.

@ronzheng1006 could you please take another look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timple @ronzheng1006 @mtlazaro