Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#179 bump nikolaposa/version dependency to 4.0.0 #199

Merged

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Feb 8, 2020

Replaces #179
Fixes #179
Fixes #37

@Ocramius Ocramius added this to the 5.0.0 milestone Feb 8, 2020
@Ocramius Ocramius self-assigned this Feb 8, 2020
@Ocramius Ocramius mentioned this pull request Feb 8, 2020
2 tasks
@Ocramius
Copy link
Member Author

Ocramius commented Feb 8, 2020

Failures from #179 are expected:

[BC] CHANGED: The return type of Roave\BackwardCompatibility\Git\GetVersionCollection#fromRepository() changed from Version\VersionsCollection to the non-covariant Version\VersionCollection

[BC] CHANGED: The return type of Roave\BackwardCompatibility\Git\GetVersionCollection#fromRepository() changed from Version\VersionsCollection to Version\VersionCollection

[BC] CHANGED: The parameter $versions of Roave\BackwardCompatibility\Git\PickLastMinorVersionFromCollection#forVersions() changed from Version\VersionsCollection to a non-contravariant Version\VersionCollection

[BC] CHANGED: The return type of Roave\BackwardCompatibility\Git\GetVersionCollectionFromGitRepository#fromRepository() changed from Version\VersionsCollection to the non-covariant Version\VersionCollection

[BC] CHANGED: The parameter $versionsCollection of Roave\BackwardCompatibility\Git\PickVersionFromVersionCollection#forVersions() changed from Version\VersionsCollection to a non-contravariant Version\VersionCollection

[BC] CHANGED: The parameter $versionsCollection of Roave\BackwardCompatibility\Git\PickVersionFromVersionCollection#forVersions() changed from Version\VersionsCollection to Version\VersionCollection

@Ocramius Ocramius merged commit b565b90 into master Feb 8, 2020
@Ocramius Ocramius deleted the feature/#179-bump-nikolaposa-version-dependency-to-4.0.0 branch February 8, 2020 19:07
@jdpedrie
Copy link

jdpedrie commented Jun 5, 2020

Can we get a release containing this fix?

@Ocramius
Copy link
Member Author

Ocramius commented Jun 5, 2020 via email

@Ocramius
Copy link
Member Author

Ocramius commented Jun 6, 2020

Seems like the failures on master are due to PHP 7.4.6, which has some very nasty bugs in yield from.

I think a release will require a "conflict": {"php": "7.4.6"} for now :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow release versions such as v1.2.3 and release-1.2.3 (as well as other patterns recognized by composer)
3 participants