-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nikolaposa/version to 4.0.0 #179
Conversation
This is just a trial run, I'll update And when I already revealed that the new release of is near, are there any other things I could address in it? |
Patch seems good so far, except for a failure: https://travis-ci.org/Roave/BackwardCompatibilityCheck/jobs/624970650#L311 As for required additions in the upstream library, there's still this bug left: #37 In practice, we need to get both the version (normalized) and the original name of the symbol that led to that version. For example, This allows us to check out symbols by their original name. |
Ok, I'll take a look at that failure. As for
I will consider some other solutions as well. |
Prefix is now preserved.
|
For fixing #37, I can consider back-porting preserving of a Version string prefix in 3.2.x of my library. |
@nikolaposa no need - can happen in the next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaposa if this passes as-is for you locally, we can merge once composer.json
changes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: will merge manually after this round of dependency upgrades is through :-)
Sounds good! |
Moved to #199 |
…on-dependency-to-4.0.0 #179 bump `nikolaposa/version` dependency to `4.0.0`
Proposed changes
Synchronize with changes made in Version 4.0.0 release.
Version
andVersionCollection
usage in accordance with their new API