Check OpenExternalWebBrowser custom flag better #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alystrasz
reviewed
Mar 2, 2024
GeckoEidechse
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Confirmed working in testing.
Before this PR:
script_ui LaunchExternalWebBrowser("http", WEBBROWSER_FLAG_FORCEEXTERNAL)would try to do a shell execute
After this PR:
the same command just opens in-game overlay browser on the specified string
Code changes to check prefix also make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.