Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check OpenExternalWebBrowser custom flag better #674

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Check OpenExternalWebBrowser custom flag better #674

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f19edf
check OpenExternalWebBrowser custom flag properly
ASpoonPlaysGames Mar 2, 2024
94c895b
allow https
ASpoonPlaysGames Mar 2, 2024
7356ec3
Merge branch 'main' into external-flags
ASpoonPlaysGames Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion primedev/scripts/client/scriptbrowserhooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ void, __fastcall, (char* pUrl, char flags))
// clang-format on
{
bool bIsOriginOverlayEnabledOriginal = *bIsOriginOverlayEnabled;
if (flags & 2 && !strncmp(pUrl, "http", 4)) // custom force external browser flag
bool isHttp = !strncmp(pUrl, "http://", 7) || !strncmp(pUrl, "https://", 8);
GeckoEidechse marked this conversation as resolved.
Show resolved Hide resolved
if (flags & 2 && isHttp) // custom force external browser flag
*bIsOriginOverlayEnabled = false; // if this bool is false, game will use an external browser rather than the origin overlay one

OpenExternalWebBrowser(pUrl, flags);
Expand Down
Loading