-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting to disable telemetry #14
Conversation
This adds a new `enableTelemetry` boolean jupyterlab setting that is checked before sending a prompt acceptance post. This new flag is enabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a minimal comment to the README explaining that there is the option to disable the telemetry.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just had a very minor suggestion
Complementing @vabarbosa comment, we should extend the comment in |
@cbjuan what should it say then? I left it open ended intentionally in case we add more telemetry |
@ajbozarth this is what @vabarbosa added into the vscode PR Qiskit/qiskit-code-assistant-vscode#101
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This adds a new
enableTelemetry
boolean JupyterLab setting that is checked before sending a POST call toprompt/<id>/acceptance
.The default value is
true
.Linked Issue(s)
Fixes #10
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Manual testing by switching the setting on and off and checking the inspector network tab to see if the
acceptance
endpoint is called after accepting a prompt in various ways.