-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a setting to enable/disable telemetry #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should extend the comment in GETTING_STARTED.md
to reflect which kind of telemetry we do gather
good idea! the comment has been updated to reflect what is collected. any feedback on the phrasing is appreciated. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments before approval. Looks good!
1. The Telemetry can be disabled by unchecking the `qiskitCodeAssistant.enableTelemetry` setting or turning `off` the `telemetry.telemetryLevel` setting: | ||
|
||
> **NOTE**: The telemetry does not collect your code nor the suggested code completions. What is collected is whether a code suggestion was accepted or dismissed. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. The Telemetry can be disabled by unchecking the `qiskitCodeAssistant.enableTelemetry` setting or turning `off` the `telemetry.telemetryLevel` setting: | |
> **NOTE**: The telemetry does not collect your code nor the suggested code completions. What is collected is whether a code suggestion was accepted or dismissed. | |
2. The Telemetry can be disabled by unchecking the `qiskitCodeAssistant.enableTelemetry` setting or turning `off` the `telemetry.telemetryLevel` setting: | |
> **NOTE**: The telemetry does not collect your code nor the suggested code completions. What is collected is whether a code suggestion was accepted or dismissed. |
shouldn't it be 2
in the numbering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the same to the README after the /~https://github.com/Qiskit/qiskit-code-assistant-vscode?tab=readme-ov-file#keyboard-shortcuts so we do the same as in jupyterlab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be
2
in the numbering?
it doesnt matter. the markdown rendering/preview will update/display the numbering correctly. i tend to just use all 1.
's so i dont have to worry about keeping them updated accordingly as we add/remove items from list.
Let's add the same to the README after the /~https://github.com/Qiskit/qiskit-code-assistant-vscode?tab=readme-ov-file#keyboard-shortcuts so we do the same as in jupyterlab
done! 23e7a76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
Description
this PR adds a new
qiskitCodeAssistant.enableTelemetry
setting to enable/disable whether telemetry is collected for the extension.Linked Issue(s)
Fixes #98
Type of change
How Has This Been Tested?
manually tested the setting on and off and confirmed whether data was sent to and collected by the server.
Checklist: