Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar Action link to PostHog after save #1313

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

This PR closes #1278. It's the simplest way I could add those links now without redoing a large part of the interface.

  • Fixes react-toastify for the toolbar
  • Adds links to Actions & Insights pages in PostHog in the toast

image

These links should go also in the actions table in some way... but that's outside the scope of this PR.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Django makemigrations ran (if this PR affects any models)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@mariusandra mariusandra requested a review from timgl July 30, 2020 14:58
@timgl timgl temporarily deployed to posthog-toolbar-actions-tvxn5m July 30, 2020 14:59 Inactive
Base automatically changed from toolbar-types to master July 30, 2020 17:17
@mariusandra mariusandra force-pushed the toolbar-actions-updates branch from da6525d to 36e856a Compare July 31, 2020 08:56
@mariusandra
Copy link
Collaborator Author

Rebased as well

@mariusandra mariusandra temporarily deployed to posthog-toolbar-actions-tvxn5m July 31, 2020 08:57 Inactive
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariusandra mariusandra merged commit 7439577 into master Aug 3, 2020
@mariusandra mariusandra deleted the toolbar-actions-updates branch August 3, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After creating an action allow user to go to that action definition
3 participants