-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHI Decoupling]Remove memory header (Part2) #50870
[PHI Decoupling]Remove memory header (Part2) #50870
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
@@ -21,7 +21,7 @@ | |||
#include "paddle/phi/kernels/funcs/distribution_helper.h" | |||
|
|||
// See Note [ Why still include the fluid headers? ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment here can also be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
谢谢,下个pr修改
@@ -24,7 +24,7 @@ | |||
#include "paddle/phi/core/visit_type.h" | |||
|
|||
// See Note [ Why still include the fluid headers? ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
谢谢,下个pr修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for CI-OP-Benchmark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
memory头文件解耦第二个PR,移除:paddle/fluid/memory/memory.h 和 paddle/fluid/memory/memcpy.h
memory解耦的第一个PR详见:#50419