[PHI Decoupling]Remove memory header (Part1) #50419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
previously approved these changes
Feb 17, 2023
|
|
||
| namespace phi { | ||
|
|
||
| struct MemoryInterface { |
There was a problem hiding this comment.
初始化 MemoryInterface 时，必须要实现此接口中的所有函数吗？
Is it necessary to implement all functions inside MemoryInterface?
There was a problem hiding this comment.
目前主框架都会用到这里的接口函数，所以必须要都实现，不过报错信息我会优化一下，以支持不需要都实现的情况
zyfncg
reviewed
Feb 17, 2023
paddle/phi/common/memory_utils.h
Outdated
| @@ -0,0 +1,175 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
| @@ -0,0 +1,175 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
| // | |||
There was a problem hiding this comment.
这个文件是不叫 memory_register 更形象些？
There was a problem hiding this comment.
该文件主要作用是为phi算子库提供memory操作相关功能，感觉memory_register表达容易让人误解
| @@ -1564,7 +1565,7 @@ void CommonGradBroadcastCUDA(const DenseTensor &x, | |||
| int y_block_size = std::min(ELEMWISE_MAX_BLOCK_DIM, y_threads); | |||
| if (dx) { | |||
| size_t dx_total_bytes = bytes * 2; | |||
| auto dx_tmp_buffer = paddle::memory::Alloc( | |||
| auto dx_tmp_buffer = phi::MemoryUtils::Instance().Alloc( | |||
There was a problem hiding this comment.
MemoryUtils的全局单例在Kernel中使用的太多看着不是很好，像paddle::memory::Alloc这样封装一个普通函数调用会比较好些，后面如果修改全局单例成本也会低一些
zyfncg
approved these changes
Feb 21, 2023
luotao1
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
本PR解耦PHI算子库依赖的Fluid头文件："paddle/fluid/memory/malloc.h"
背景：
PHI算子库正在进行解耦Fluid的工作，其中有一类memory相关的Fluid头文件，由于其深度依赖Fluid，无法通过常规方法将其与PHI解耦，本PR通过抽象设计出一套接口层来实现PHI和Fluid的memory头文件解耦。
解决方法：
设计了一个MemoryInterface来实现解耦，整体设计如下图所示：
其中，MemoryUtils用来管理MemoryInterface对象，PHI算子库的其他部件通过使用MemoryUtils来调用MemoryInterface定义的接口功能。
MemoryInterface定义了外部库使用PHI算子库所要实现的内存管理功能，该接口暴露给PHI之外的库，不同库可以按照定义好的接口标准进行实现，从而将自己的内存管理功能接入PHI算子库。