Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Op::GetAttr to Op::Attr #3903

Merged
merged 3 commits into from
Sep 6, 2017
Merged

Change Op::GetAttr to Op::Attr #3903

merged 3 commits into from
Sep 6, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 6, 2017

Fix #3902

@reyoung reyoung requested a review from jacquesqiao September 6, 2017 05:04
jacquesqiao
jacquesqiao previously approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingqing01 qingqing01 mentioned this pull request Sep 6, 2017
Merged
jacquesqiao
jacquesqiao approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reyoung reyoung merged commit e888175 into PaddlePaddle:develop Sep 6, 2017
@reyoung reyoung deleted the feature/change_get_attr_to_attr branch October 2, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @jacquesqiao