Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GetAttr to Attr in OperatorBase/InferShapeContext #3902

Closed
reyoung opened this issue Sep 6, 2017 · 0 comments
Closed

Change GetAttr to Attr in OperatorBase/InferShapeContext #3902

reyoung opened this issue Sep 6, 2017 · 0 comments

Comments

@reyoung
Copy link
Collaborator

reyoung commented Sep 6, 2017

In OperatorBase and InferShapeContext, two kinds of API are mixed together. They are

  • Input, Output
  • GetAttr

So we should change it either GetInput, GetOutput or Attr. Since Attr is simpler than GetAttr, so maybe Attr is better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reyoung