Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GetPlace<T> to ExecutionContext #4206

Closed
wants to merge 1 commit into from
Closed

add GetPlace<T> to ExecutionContext #4206

wants to merge 1 commit into from

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Sep 19, 2017 •
edited
Loading

fix #4203

Yancey1989
Yancey1989 reviewed Sep 20, 2017
View reviewed changes
paddle/framework/operator.h
@@ -376,6 +376,11 @@ class ExecutionContext : public InferShapeContext {

platform::Place GetPlace() const { return device_context_.GetPlace(); }

template <typename PlaceType>
platform::Place GetPlace() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #3902 , maybe we can keep the style and rename the function name to Place(), so we can use it as:

ctx.Place<PlaceType>();

@jacquesqiao jacquesqiao closed this Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need an interface to get Place instance
2 participants
@jacquesqiao @Yancey1989