[new api] add new api paddle.quantile and paddle.Tensor.quantile #38567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zoooo0820
force-pushed
the
quantile_api
branch
from
9e30b94 to
44c235a
Compare
zoooo0820
force-pushed
the
quantile_api
branch
from
44c235a to
15293c9
Compare
jeff41404
reviewed
Dec 30, 2021
Comment on lines
27
to
28
| for q_num in q: | ||
| output.append(np.quantile(x, q_num, axis=axis, keepdims=keepdims)) |
There was a problem hiding this comment.
np.quantile support q as array, call np.quantile once instead of loop?
There was a problem hiding this comment.
done, use np.quantile directly.
jeff41404
reviewed
Dec 30, 2021
Comment on lines
+440
to
+448
| if (indices_upper[i] != indices_below[i]): | ||
| tensor_below = paddle.take_along_axis(sorted_tensor, | ||
| indices_below[i], axis) | ||
| tensor_upper = paddle.take_along_axis(sorted_tensor, | ||
| indices_upper[i], axis) | ||
| weights = (indices[i] - indices_below[i]).astype(x.dtype) | ||
| out = paddle.lerp(tensor_below, tensor_upper, weights) | ||
| else: | ||
| out = paddle.take_along_axis(sorted_tensor, indices_below[i], axis) |
There was a problem hiding this comment.
paddle.take_along_axis should support list of index, if there is something wrong, add to do and issue it.
dingjiaweiww
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
add new api paddle.quantile and paddle.Tensor.quantile