Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update pathfinding when changing rolling stock #9553

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Nov 4, 2024

close #8570

For tested:

  • Create a PF that is invalid due to constraints ( ex: PLY -> MSC with RS 2500V) incompatibilities will be displayed at the bottom of the map.
  • Change RS for thermic, back to the Itinerary tab the incompatibilities should no longer appear.

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner November 4, 2024 14:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.50%. Comparing base (fb3a2b1) to head (e8036a0).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ents/RollingStockSelector/RollingStockSelector.tsx 0.00% 4 Missing ⚠️
...s/operationalStudies/views/ManageTrainSchedule.tsx 0.00% 2 Missing ⚠️
...nt/src/modules/pathfinding/hooks/usePathfinding.ts 0.00% 2 Missing ⚠️
...les/pathfinding/components/Itinerary/Itinerary.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9553      +/-   ##
============================================
- Coverage     42.51%   42.50%   -0.02%     
  Complexity     2272     2272              
============================================
  Files          1312     1312              
  Lines        105563   105570       +7     
  Branches       3304     3304              
============================================
- Hits          44879    44868      -11     
- Misses        58731    58749      +18     
  Partials       1953     1953              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.73% <ø> (-0.04%) ⬇️
front 18.79% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-update-pathfinding branch 2 times, most recently from 8b4abd1 to 088a939 Compare November 7, 2024 09:17
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice work !

@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-update-pathfinding branch 4 times, most recently from f507a70 to 45c665c Compare November 8, 2024 10:37
  - As the hook usePathfinding were only in the Itinerary tab, the
    pathfinding was not updated when rolling stock was changed

Signed-off-by: Uriel Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-update-pathfinding branch from 45c665c to e8036a0 Compare November 8, 2024 10:49
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit 9a48bc9 Nov 8, 2024
25 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/fix-update-pathfinding branch November 8, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the rolling stock to make an invalid train valid does not exit the pathfinding debug interface
4 participants