-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: avoid useless query on editor for switch types and infra #7904
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7904 +/- ##
============================================
- Coverage 28.54% 28.51% -0.04%
Complexity 2059 2059
============================================
Files 1249 1251 +2
Lines 154182 154232 +50
Branches 3036 3038 +2
============================================
- Hits 44009 43972 -37
- Misses 108363 108448 +85
- Partials 1810 1812 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c90cb07
to
dbd4ebd
Compare
@emersion Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, left some comments.
Do you think we could also make an improvement when hovering a tracksection to avoid calling it each time ?
Fix #6971 Unsubscribe some RTK queries to avoid useless queries, by creating wrapper for useInfra & useSwitchType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked into all of the details, but couldn't spot anything else!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
Fix #6971