Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add vias in stdcm simulation #7818

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #7714

@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch 2 times, most recently from bad7ca6 to 5c18d2a Compare June 26, 2024 07:00
@SarahBellaha SarahBellaha marked this pull request as ready for review June 26, 2024 07:00
@SarahBellaha SarahBellaha requested a review from a team as a code owner June 26, 2024 07:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 13.01703% with 715 lines in your changes missing coverage. Please review.

Project coverage is 28.35%. Comparing base (c61b95f) to head (129d5f8).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ont/src/modules/pathfinding/hook/usePathfinding.ts 28.91% 219 Missing and 17 partials ⚠️
...rc/applications/stdcmV2/components/StdcmConfig.tsx 0.00% 124 Missing and 1 partial ⚠️
.../src/applications/stdcmV2/components/StdcmVias.tsx 0.00% 104 Missing and 1 partial ⚠️
...ont/src/modules/pathfinding/hook/useInfraStatus.ts 10.97% 73 Missing ⚠️
.../applications/stdcmV2/components/StdcmInputVia.tsx 0.00% 40 Missing and 1 partial ⚠️
...rc/applications/stdcmV2/components/StdcmOrigin.tsx 0.00% 30 Missing and 1 partial ⚠️
...plications/stdcmV2/components/StdcmDestination.tsx 0.00% 27 Missing and 1 partial ⚠️
...c/applications/stdcmV2/components/StdcmConsist.tsx 0.00% 18 Missing ⚠️
...ont/src/applications/stdcmV2/views/StdcmViewV2.tsx 0.00% 14 Missing and 1 partial ⚠️
...thfinding/components/Pathfinding/PathfindingV2.tsx 0.00% 8 Missing and 1 partial ⚠️
... and 10 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7818      +/-   ##
============================================
- Coverage     28.42%   28.35%   -0.07%     
  Complexity     2059     2059              
============================================
  Files          1264     1269       +5     
  Lines        155100   155395     +295     
  Branches       3053     3055       +2     
============================================
- Hits          44082    44062      -20     
- Misses       109197   109509     +312     
- Partials       1821     1824       +3     
Flag Coverage Δ
core 75.00% <ø> (ø)
editoast 71.61% <ø> (-0.03%) ⬇️
front 9.95% <13.01%> (-0.04%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch from 5c18d2a to 7fb5d3e Compare June 26, 2024 07:06
@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch 4 times, most recently from ccc74bf to f2e6264 Compare June 26, 2024 13:06
@SarahBellaha SarahBellaha requested a review from SharglutDev June 26, 2024 14:45
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR !

front/src/modules/pathfinding/hook/usePathfinding.ts Outdated Show resolved Hide resolved
front/src/modules/pathfinding/hook/useInfra.ts Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/views/StdcmViewV2.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmVias.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmVias.tsx Outdated Show resolved Hide resolved
front/public/locales/en/stdcm.json Outdated Show resolved Hide resolved
front/public/locales/fr/stdcm.json Show resolved Hide resolved
@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch from 5bda74a to 917a1e4 Compare June 28, 2024 10:43
@SharglutDev
Copy link
Contributor

SharglutDev commented Jun 28, 2024

You also have a conflict in PathfindingV2.tsx coming from this pr : #7880.
You can check the changes in it to help with conflicts.

@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch from 917a1e4 to 058e73e Compare July 2, 2024 08:00
@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch from 058e73e to 2fc6630 Compare July 2, 2024 09:29
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, a few more comments before probably the end of this PR :)

@theocrsb
Copy link
Contributor

theocrsb commented Jul 2, 2024

When I tried to have a simulation, I got an error 500. I think it's because the duration is null in the payload

image

@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch 6 times, most recently from 089c491 to f49c0d9 Compare July 3, 2024 16:07
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! One last comment, you can just fix the last comment and your commits and you can merge :)

front/src/modules/pathfinding/hook/usePathfinding.ts Outdated Show resolved Hide resolved
@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch 5 times, most recently from 25f492a to ef8baae Compare July 4, 2024 10:26
@SarahBellaha SarahBellaha force-pushed the sba/front/add-vias-in-stdcm-simulation-7714 branch from ef8baae to 129d5f8 Compare July 4, 2024 10:29
@SharglutDev SharglutDev added this pull request to the merge queue Jul 4, 2024
@flomonster flomonster removed this pull request from the merge queue due to a manual request Jul 4, 2024
@flomonster flomonster merged commit 2c70a65 into dev Jul 4, 2024
17 checks passed
@flomonster flomonster deleted the sba/front/add-vias-in-stdcm-simulation-7714 branch July 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: stdcm: add vias in stdcm simulation
8 participants