-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add vias in stdcm simulation #7818
Conversation
bad7ca6
to
5c18d2a
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7818 +/- ##
============================================
- Coverage 28.42% 28.35% -0.07%
Complexity 2059 2059
============================================
Files 1264 1269 +5
Lines 155100 155395 +295
Branches 3053 3055 +2
============================================
- Hits 44082 44062 -20
- Misses 109197 109509 +312
- Partials 1821 1824 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5c18d2a
to
7fb5d3e
Compare
ccc74bf
to
f2e6264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR !
5bda74a
to
917a1e4
Compare
You also have a conflict in PathfindingV2.tsx coming from this pr : #7880. |
917a1e4
to
058e73e
Compare
058e73e
to
2fc6630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, a few more comments before probably the end of this PR :)
089c491
to
f49c0d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job ! One last comment, you can just fix the last comment and your commits and you can merge :)
25f492a
to
ef8baae
Compare
ef8baae
to
129d5f8
Compare
Closes #7714