front: fix trains not stopping at the end of path #7880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7880 +/- ##
============================================
- Coverage 28.54% 28.54% -0.01%
+ Complexity 2060 2059 -1
============================================
Files 1249 1249
Lines 154183 154210 +27
Branches 3041 3036 -5
============================================
+ Hits 44015 44016 +1
- Misses 108354 108384 +30
+ Partials 1814 1810 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
force-pushed
the
pfn/front/fix-train-not-stopping-at-end
branch
from
6507994 to
3a0958a
Compare
SharglutDev
force-pushed
the
pfn/front/fix-train-not-stopping-at-end
branch
from
3a0958a to
f8615b6
Compare
|
I realize that there are some duplication of code used for starting pathfinding in |
kmer2016
reviewed
Jun 28, 2024
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
Outdated
Show resolved
Hide resolved
SharglutDev
force-pushed
the
pfn/front/fix-train-not-stopping-at-end
branch
from
f8615b6 to
5710204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7868
Use dayjs to transform a duration in ISO8601 in seconds so that it's resilient to any format of ISO8601 (not only PTxxx)
close #7863
By default, we add a 0sec stopFor for the destination when launching the pathfinding