actions: use artifacts instead of registry for forks #7558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OpenRailAssociation#7549 we tried to fix CI for external contributors by using the fork repo registry instead of the base repo registry. Unfortunately GITHUB_TOKEN cannot be used to write to the fork repo registry, it only has read access to the base repo registry. Instead, use artifacts to pass around built Docker images. Co-authored-by: Simon Ser <contact@emersion.fr>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7558 +/- ##
=============================================
- Coverage 29.37% 10.38% -18.99%
=============================================
Files 1200 586 -614
Lines 147415 103429 -43986
Branches 2894 979 -1915
=============================================
- Hits 43296 10743 -32553
+ Misses 102415 91714 -10701
+ Partials 1704 972 -732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
multun
approved these changes
May 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7549 we tried to fix CI for external contributors by using the fork repo registry instead of the base repo registry. Unfortunately GITHUB_TOKEN cannot be used to write to the fork repo registry, it only has read access to the base repo registry.
Instead, use artifacts to pass around built Docker images.
Based on #7554 (but doesn't attempt to re-arrange the actions workflow).
There is quite a lot of boilerplate due to uploading/downloading/loading individual images. We could reduce that boilerplate by always uploading/downloading all images (at the cost of more time spent downloading stuff we won't use), or introducing a re-usable step in a separate yaml file.