Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: fix PRs from forks #7549

Merged
merged 3 commits into from
May 29, 2024
Merged

actions: fix PRs from forks #7549

merged 3 commits into from
May 29, 2024

Conversation

multun
Copy link
Contributor

@multun multun commented May 29, 2024

This PR is best reviewed commit by commit

@multun multun requested a review from a team as a code owner May 29, 2024 13:47
@multun multun changed the title actions: remove the image namer concept from bake-metadata.py actions: fix PRs from forks May 29, 2024
@multun multun force-pushed the fix-actions-fork branch from cd1ed89 to 65b1eac Compare May 29, 2024 13:48
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (08271f1) to head (ea08924).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7549       +/-   ##
=============================================
+ Coverage     29.38%   87.49%   +58.10%     
=============================================
  Files          1200       31     -1169     
  Lines        147488     1535   -145953     
  Branches       2894        0     -2894     
=============================================
- Hits          43343     1343    -42000     
+ Misses       102441      192   -102249     
+ Partials       1704        0     -1704     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multun multun force-pushed the fix-actions-fork branch from ea08924 to 2861007 Compare May 29, 2024 14:26
@multun multun merged commit 2e929c8 into dev May 29, 2024
9 checks passed
@multun multun deleted the fix-actions-fork branch May 29, 2024 14:30
emersion added a commit to emersion/osrd that referenced this pull request May 30, 2024
In OpenRailAssociation#7549 we tried to fix CI for external contributors by using the
fork repo registry instead of the base repo registry. Unfortunately
GITHUB_TOKEN cannot be used to write to the fork repo registry, it
only has read access to the base repo registry.

Instead, use artifacts to pass around built Docker images.

Co-authored-by: Simon Ser <contact@emersion.fr>
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
In #7549 we tried to fix CI for external contributors by using the
fork repo registry instead of the base repo registry. Unfortunately
GITHUB_TOKEN cannot be used to write to the fork repo registry, it
only has read access to the base repo registry.

Instead, use artifacts to pass around built Docker images.

Co-authored-by: Simon Ser <contact@emersion.fr>
leovalais pushed a commit that referenced this pull request May 30, 2024
In #7549 we tried to fix CI for external contributors by using the
fork repo registry instead of the base repo registry. Unfortunately
GITHUB_TOKEN cannot be used to write to the fork repo registry, it
only has read access to the base repo registry.

Instead, use artifacts to pass around built Docker images.

Co-authored-by: Simon Ser <contact@emersion.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants