Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix v2 path_with_repeated_tracks bug which ignored track direction #7474

Merged
merged 1 commit into from
May 22, 2024

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented May 22, 2024

Path_with_repeated tracks was thrown when two tracks had the same string in the pathfinding result, even with different directions.

@Erashin Erashin requested a review from a team as a code owner May 22, 2024 06:57
@Erashin Erashin requested a review from eckter May 22, 2024 06:57
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.36%. Comparing base (afc1c50) to head (f914e2c).

Files Patch % Lines
.../api_v2/pathfinding/PathfindingBlocksEndpointV2.kt 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7474      +/-   ##
============================================
- Coverage     29.36%   29.36%   -0.01%     
  Complexity     2012     2012              
============================================
  Files          1177     1177              
  Lines        145975   145975              
  Branches       2871     2871              
============================================
- Hits          42867    42864       -3     
- Misses       101423   101426       +3     
  Partials       1685     1685              
Flag Coverage Δ
core 75.13% <66.66%> (ø)
editoast 72.32% <ø> (-0.02%) ⬇️
front 9.79% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/fix-path_with_repeated_tracks branch from c6e968f to d7c30b0 Compare May 22, 2024 07:07
@Erashin Erashin self-assigned this May 22, 2024
@Erashin Erashin force-pushed the alch/fix-path_with_repeated_tracks branch from d7c30b0 to f914e2c Compare May 22, 2024 08:39
@Erashin Erashin added this pull request to the merge queue May 22, 2024
Merged via the queue into dev with commit d341b3e May 22, 2024
17 checks passed
@Erashin Erashin deleted the alch/fix-path_with_repeated_tracks branch May 22, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants