core: fix v2 path_with_repeated_tracks by checking track with directi…

…on duplicates in path
OpenRailAssociation · May 22, 2024 · d7c30b0 · d7c30b0
1 parent afc1c50
commit d7c30b0
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/core/src/main/kotlin/fr/sncf/osrd/api/api_v2/pathfinding/PathfindingBlocksEndpointV2.kt b/core/src/main/kotlin/fr/sncf/osrd/api/api_v2/pathfinding/PathfindingBlocksEndpointV2.kt
@@ -307,10 +307,16 @@ fun validatePathfindingResponse(
         }
     }
 
-    val tracks = HashSet<String>()
-    for (track in res.trackSectionRanges) tracks.add(track.trackSection)
-    if (tracks.size != res.trackSectionRanges.size)
-        throw OSRDError(ErrorType.PathWithRepeatedTracks)
+    val dirTrackDuplicates =
+        res.trackSectionRanges.filter { trackSectionRange ->
+            res.trackSectionRanges
+                .filter {
+                    trackSectionRange.trackSection == it.trackSection &&
+                        trackSectionRange.direction == it.direction
+                }
+                .size > 1
+        }
+    if (dirTrackDuplicates.isNotEmpty()) throw OSRDError(ErrorType.PathWithRepeatedTracks)
 
     if (res.pathItemPositions.size != req.pathItems.size)
         throw OSRDError(ErrorType.PathHasInvalidItemPositions)