editoast: change from 'env_logger' to 'tracing-subscriber' #6650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6650 +/- ##
============================================
- Coverage 27.75% 27.73% -0.02%
Complexity 2172 2172
============================================
Files 1041 1042 +1
Lines 128289 128465 +176
Branches 2569 2569
============================================
+ Hits 35608 35633 +25
- Misses 91196 91347 +151
Partials 1485 1485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
woshilapin
force-pushed
the
wsl/feat/env_logger-to-tracing
branch
2 times, most recently
from
e219c0d to
99fb4b5
Compare
woshilapin
force-pushed
the
wsl/feat/env_logger-to-tracing
branch
from
99fb4b5 to
0579b84
Compare
4 tasks
With the objective to instrument `editoast` with OpenTelemetry, let's use `tracing-subscriber` which will allow to configure a stdout logger with an Opentelemetry emitter.
woshilapin
force-pushed
the
wsl/feat/env_logger-to-tracing
branch
from
0579b84 to
61ee41e
Compare
Wadjetz
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the objective to instrument
editoastwith OpenTelemetry, let's usetracing-subscriberwhich will allow configuring a stdout logger with an Opentelemetry emitter.See also #6649 for the change to
tracingfor the log's record emission.Before
After