editoast: replace log with tracing #6649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the objective to instrument `editoast` with OpenTelemetry, `tracing` can bring some ease-of-use macros for instrumenting functions. This PR is a first step to move to `tracing` (only the log event generation).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6649 +/- ##
============================================
- Coverage 27.87% 27.87% -0.01%
Complexity 2171 2171
============================================
Files 1044 1044
Lines 127905 127909 +4
Branches 2601 2601
============================================
- Hits 35656 35655 -1
- Misses 90731 90736 +5
Partials 1518 1518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shenriotpro
approved these changes
Feb 15, 2024
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the objective to instrument
editoastwith OpenTelemetry,tracingcan bring some ease-of-use macros for instrumenting functions.This PR is a first step to move to
tracing(only the log event generation). See also #6650 for converting the log's records listener.